Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modeling / Mixtral] Fix GC + PEFT issues with Mixtral #28061

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

younesbelkada
Copy link
Contributor

@younesbelkada younesbelkada commented Dec 15, 2023

What does this PR do?

Applies the same fix presented in #28031 for Mixtral, specifically addresses: #28023 (comment)

cc @amyeroberts

Fixes: huggingface/trl#1088

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a need to popagate further no?

@younesbelkada
Copy link
Contributor Author

Thanks ! As far as I know all models that uses the new cache refactor have been fixed in #28031 + this PR

@younesbelkada younesbelkada merged commit e737446 into huggingface:main Dec 15, 2023
18 checks passed
@younesbelkada younesbelkada deleted the fix-gc-mixtral branch December 15, 2023 10:34
iantbutler01 pushed a commit to BismuthCloud/transformers that referenced this pull request Dec 16, 2023
amyeroberts pushed a commit that referenced this pull request Dec 18, 2023
staghado pushed a commit to staghado/transformers that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError when using gradient_checkpointing with SFTTrainer
3 participants