-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FA-2
] Fix fa-2 issue when passing config
to from_pretrained
#28043
Merged
younesbelkada
merged 12 commits into
huggingface:main
from
younesbelkada:fix-fa-2-from-config
Dec 15, 2023
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
021a6ed
fix fa-2 issue
younesbelkada 19ef983
fix test
younesbelkada cfb2f4e
Update src/transformers/modeling_utils.py
younesbelkada dec3754
clenaer fix
younesbelkada a2c566e
up
younesbelkada a9be74d
add more robust tests
younesbelkada 8160f44
Merge remote-tracking branch 'upstream/main' into fix-fa-2-from-config
younesbelkada 8476ea1
Update src/transformers/modeling_utils.py
younesbelkada 6571ec8
fixup
younesbelkada f45eb42
Update src/transformers/modeling_utils.py
younesbelkada 9068a89
pop
younesbelkada 4d0366e
add test
younesbelkada File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test for e.g. llama + passing a config +
attn_implementation="flash_attention_2
that the correct class is loaded?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean without
AutoModel
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean a test for an architecture that do support FA2, passing both a config +
attn_implementation="flash_attention_2"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!