Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Processor #27761

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Save Processor #27761

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d8aa40
save processor
ydshieh Jan 11, 2024
6dd7f29
Update tests/models/auto/test_processor_auto.py
ydshieh Jan 12, 2024
ff2274e
Update tests/test_processing_common.py
ydshieh Jan 12, 2024
b649360
fix
ydshieh Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update tests/test_processing_common.py 
Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
  • Loading branch information
@ydshieh @ArthurZucker
ydshieh and ArthurZucker committed Jan 17, 2024
commit ff2274e73292760b14a792468f76d8afb148b313
2 changes: 1 addition & 1 deletion tests/test_processing_common.py
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add tests to make sure we only call the hub once, make sure kwargs passed to the processor class are correctly forwarded to the init of the tokenizer and the feature extractor (specifically trust_remote_code, and additional kwargs that do not exist are not duplicated)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure we only call the hub once

We have such test for processors, but yes we need to test this with the a processor class whose init has extra kwargs and with a "processor_config.json" on the Hub. However, we don't have such process yet ...

kwargs passed to the processor class are correctly forwarded to the init of the tokenizer and the feature extractor

So far, the processor classes don't have kwargs, not even in this PR. The initialization of the tokenizer and the feature extractor is not through the initialization of processor class: they are created , then are send to processor class' init.

Note: the extra kwargs we would like to have in a processor class, IMO, are not designed to control the tokenizer/feature extractor at their creation time.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add tests to make sure we only call the hub once

well, I found we only have this tests for torch/tf model, tokenizer and pipeline (in auto). Not sure why we don't have this for image/feature extractor/processor.

Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# coding=utf-8
# Copyright 2023 The HuggingFace Inc. team. All rights reserved.
# Copyright 2024 The HuggingFace Inc. team. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down