Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Whisper] Finalize batched SOTA long-form generation #27658

Merged
merged 87 commits into from
Jan 19, 2024
+1,825 −852
Merged

[Whisper] Finalize batched SOTA long-form generation #27658

Changes from 1 commit
Commits
Show all changes
87 commits
Select commit Hold shift + click to select a range
8530d3d
finalize
patrickvonplaten Nov 22, 2023
c4826fd
make fix copies whisper
patrickvonplaten Nov 27, 2023
2de5fe0
[Tests] Make sure that we don't run tests mulitple times
patrickvonplaten Nov 27, 2023
3106c51
Update src/transformers/models/whisper/modeling_whisper.py
patrickvonplaten Nov 27, 2023
cfc1998
[Tests] Make sure that we don't run tests mulitple times
patrickvonplaten Nov 28, 2023
0ca149b
Merge branch 'improve_decoding' of https://github.com/huggingface/tra…
patrickvonplaten Nov 28, 2023
00df894
fix more
patrickvonplaten Dec 1, 2023
25bcd69
improve
patrickvonplaten Dec 2, 2023
30a78a3
improve
patrickvonplaten Dec 2, 2023
e3bff24
improve further
patrickvonplaten Dec 2, 2023
25c9345
improve more
patrickvonplaten Dec 2, 2023
cd7734b
improve
patrickvonplaten Dec 4, 2023
3cf1752
fix more
patrickvonplaten Dec 4, 2023
48c2e60
Merge branch 'improve_decoding' of https://github.com/huggingface/tra…
patrickvonplaten Dec 4, 2023
133d17e
git commit and git push
patrickvonplaten Dec 4, 2023
e86745a
fix more
patrickvonplaten Dec 4, 2023
cbae58c
fix more
patrickvonplaten Dec 4, 2023
3933896
fix more
patrickvonplaten Dec 4, 2023
0e413e7
New try
patrickvonplaten Dec 5, 2023
8411a9e
Fix more whisper stuff
patrickvonplaten Dec 5, 2023
45d1233
Merge branch 'main' of https://github.com/huggingface/transformers in…
patrickvonplaten Dec 5, 2023
10cfdc6
Improve
patrickvonplaten Dec 5, 2023
b0897c7
correct more
patrickvonplaten Dec 7, 2023
24fa463
correct more
patrickvonplaten Dec 7, 2023
e0b7af3
correct more
patrickvonplaten Dec 7, 2023
5a67f75
Fix some tests
patrickvonplaten Dec 7, 2023
404d542
Add more tests
patrickvonplaten Dec 7, 2023
46cdb43
correct more
patrickvonplaten Dec 8, 2023
6818ebf
correct more
patrickvonplaten Dec 8, 2023
b46b63d
correct more
patrickvonplaten Dec 8, 2023
184c888
push
patrickvonplaten Dec 9, 2023
e4b7827
correct more
patrickvonplaten Dec 9, 2023
380bd54
Fix more
patrickvonplaten Dec 9, 2023
3e49df8
Better
patrickvonplaten Dec 9, 2023
c2387ed
without dec mask
patrickvonplaten Dec 9, 2023
1cca405
correct more
patrickvonplaten Dec 10, 2023
29a9830
clean
patrickvonplaten Dec 10, 2023
032d45a
save intermediate
patrickvonplaten Dec 10, 2023
0724d47
correct more
patrickvonplaten Dec 10, 2023
06b598a
Fix more
patrickvonplaten Dec 10, 2023
d1021ec
Fix VAD for large-v2
patrickvonplaten Dec 12, 2023
23d2149
Save new
patrickvonplaten Dec 13, 2023
1caa2cb
Correct more
patrickvonplaten Dec 13, 2023
947e542
make cleaner
patrickvonplaten Dec 13, 2023
6f01cdb
merge from main
patrickvonplaten Dec 13, 2023
c0d03af
correct tests
patrickvonplaten Dec 13, 2023
abb3d56
correct src
patrickvonplaten Dec 13, 2023
a8b8446
Finish
patrickvonplaten Dec 19, 2023
875beab
Fix more
patrickvonplaten Dec 19, 2023
9d31fda
Merge branch 'main' of https://github.com/huggingface/transformers in…
patrickvonplaten Dec 19, 2023
39034c7
Fix more
patrickvonplaten Dec 19, 2023
66c08ee
finish
patrickvonplaten Dec 19, 2023
a6cb9ba
rebase
patrickvonplaten Jan 2, 2024
254026c
Fix edge cases
patrickvonplaten Jan 2, 2024
85c68f2
fix return_dict_in_generate
patrickvonplaten Jan 3, 2024
c2fa76a
fix all tests
patrickvonplaten Jan 3, 2024
affdb6d
make style
patrickvonplaten Jan 3, 2024
bf7ee48
add docstrings
patrickvonplaten Jan 3, 2024
8096e4a
add docstrings
patrickvonplaten Jan 3, 2024
bd8c076
Merge branch 'main' of https://github.com/huggingface/transformers in…
patrickvonplaten Jan 6, 2024
f667fc4
Fix logit processor
patrickvonplaten Jan 8, 2024
5d976b0
Merge branch 'main' of https://github.com/huggingface/transformers in…
patrickvonplaten Jan 8, 2024
33b1903
make style
patrickvonplaten Jan 8, 2024
76134ec
fix pipeline test
patrickvonplaten Jan 8, 2024
8f00ba3
fix more style
patrickvonplaten Jan 8, 2024
5634a64
Apply suggestions from code review
patrickvonplaten Jan 8, 2024
667e03e
fix merge conflict
patrickvonplaten Jan 16, 2024
530c246
apply feedback Sanchit
patrickvonplaten Jan 16, 2024
d1662af
correct more
patrickvonplaten Jan 16, 2024
d22a9b3
Apply suggestions from code review
patrickvonplaten Jan 16, 2024
c34574f
Apply suggestions from code review
patrickvonplaten Jan 16, 2024
0e7c86e
correct more
patrickvonplaten Jan 16, 2024
67c2ea4
correct more
patrickvonplaten Jan 16, 2024
c9da44d
correct more
patrickvonplaten Jan 16, 2024
6541bac
Fix staticmethod
patrickvonplaten Jan 16, 2024
aae16f3
correct more
patrickvonplaten Jan 16, 2024
d24a4d8
fix
patrickvonplaten Jan 16, 2024
85ec8fe
fix slow tests
patrickvonplaten Jan 16, 2024
32b745c
make style
patrickvonplaten Jan 16, 2024
113d678
fix tokenizer test
patrickvonplaten Jan 17, 2024
de34f23
fix tokenizer test
patrickvonplaten Jan 17, 2024
55817e2
Merge branch 'main' of https://github.com/huggingface/transformers in…
patrickvonplaten Jan 17, 2024
d26b2e4
Merge branch 'main' of https://github.com/huggingface/transformers in…
patrickvonplaten Jan 19, 2024
db02e95
Apply suggestions from code review
patrickvonplaten Jan 19, 2024
71b4893
finish
patrickvonplaten Jan 19, 2024
e3711a3
finish
patrickvonplaten Jan 19, 2024
e9673c5
revert kwargs change
patrickvonplaten Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix return_dict_in_generate
  • Loading branch information
@patrickvonplaten
patrickvonplaten committed Jan 3, 2024
commit 85c68f298b990b71d3650a4a7bb07f8a550e62d7
1 change: 0 additions & 1 deletion src/transformers/models/whisper/generation_whisper.py
View file
Open in desktop
patrickvonplaten marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,6 @@ def generate(
stopping_criteria,
prefix_allowed_tokens_fn,
synced_gpus,
return_dict_in_generate=return_dict_in_generate,
**kwargs,
)

Expand Down