Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BartModel #2745

Merged
merged 168 commits into from
Feb 20, 2020
Merged

Add BartModel #2745

Changes from 1 commit
Commits
Show all changes
168 commits
Select commit Hold shift + click to select a range
b5c20db
3 new files
sshleifer Jan 23, 2020
8420dc5
Lots of fairseq copy paste
sshleifer Jan 24, 2020
22ccda1
typo idiocy
sshleifer Jan 24, 2020
03d2cf3
Copy paste code that we know we wont use
sshleifer Jan 24, 2020
d99326e
before consider Roberta way
sshleifer Jan 24, 2020
43c7e21
add tokenization: identical to Roberta
sshleifer Jan 25, 2020
24fb639
register in configuration auto
sshleifer Jan 25, 2020
61409b4
mid consolidation of fairseq heirarchy
sshleifer Jan 26, 2020
0b79f39
Forward works, but shapes are wrong
sshleifer Jan 27, 2020
dcf2b88
copy pasted tests
sshleifer Jan 27, 2020
92e487f
matching state dict after upgrade
sshleifer Jan 30, 2020
e0c54ed
Merge remote-tracking branch 'upstream/master' into bart
sshleifer Jan 31, 2020
3871a7a
rm typo
sshleifer Jan 31, 2020
dbe83c9
del maybe layernorm
sshleifer Feb 2, 2020
2373e8a
Delete more maybe_layer_norm
sshleifer Feb 2, 2020
0dda528
Moved code round
sshleifer Feb 2, 2020
69327e4
fixed base tests, some notimpl for attention module
sshleifer Feb 3, 2020
d630887
config cleanup
sshleifer Feb 3, 2020
3cbc6ca
Some test cleanup
sshleifer Feb 4, 2020
51ab277
Merge branch 'master' into bart
sshleifer Feb 4, 2020
9e694a7
fixed attn weights shape failure with big copy paste
sshleifer Feb 4, 2020
f355e36
passing hidden_states shape test
sshleifer Feb 4, 2020
3971d97
initializer_factor, passing more tests
sshleifer Feb 5, 2020
f42997f
Merge remote-tracking branch 'upstream/master' into bart
sshleifer Feb 5, 2020
56c4744
utests pass
sshleifer Feb 5, 2020
26656a0
del unused file
sshleifer Feb 5, 2020
4d77a7c
whitespace
sshleifer Feb 5, 2020
0ce724a
Merge remote-tracking branch 'upstream/master' into bart
sshleifer Feb 5, 2020
38e057f
trailing comma
sshleifer Feb 5, 2020
a48f89e
make style, quality
sshleifer Feb 5, 2020
2ad6e7b
remove fairseq dep
sshleifer Feb 5, 2020
a772509
Undo error type change
sshleifer Feb 5, 2020
831fd14
whitespace
sshleifer Feb 5, 2020
be62f89
fix fstring
sshleifer Feb 5, 2020
6726d33
black
sshleifer Feb 5, 2020
c0e9510
type hinting only in comments for py35
sshleifer Feb 5, 2020
28bcf61
more style
sshleifer Feb 5, 2020
1f0b885
isort
sshleifer Feb 5, 2020
6aea2b8
fix NameError
sshleifer Feb 5, 2020
4e7279c
del methods
sshleifer Feb 5, 2020
28345b4
del methods
sshleifer Feb 5, 2020
effa170
F.gelu
sshleifer Feb 5, 2020
8c7df3a
small
sshleifer Feb 5, 2020
cee5051
style
sshleifer Feb 5, 2020
586098d
Working conversion script
sshleifer Feb 6, 2020
67b02c6
cleaning
sshleifer Feb 6, 2020
3811209
test init more directly
sshleifer Feb 6, 2020
28c977b
more variance checks
sshleifer Feb 6, 2020
b79509d
hardcoding expected results
sshleifer Feb 6, 2020
5bc3081
undo stupid change
sshleifer Feb 6, 2020
df6edc3
idiot
sshleifer Feb 6, 2020
5eaade8
delete torch version
sshleifer Feb 6, 2020
edc492e
cleanup, passing
sshleifer Feb 6, 2020
7c090b0
cleanup, passing
sshleifer Feb 6, 2020
1d6cde6
passing
sshleifer Feb 6, 2020
1c06538
Style
sshleifer Feb 6, 2020
73cad04
more deletion
sshleifer Feb 6, 2020
a68c20e
cleanup style, passing
sshleifer Feb 6, 2020
5d1bc99
resize_embeddings test passing
sshleifer Feb 6, 2020
c23a07b
AutoTokenizer support
sshleifer Feb 7, 2020
67ef42f
one file
sshleifer Feb 7, 2020
7a4a6e2
Fix class ordering
sshleifer Feb 7, 2020
f80ce45
conversion broken
sshleifer Feb 7, 2020
42e061b
some old changes
sshleifer Feb 7, 2020
28b1f80
conversion scripts work
sshleifer Feb 7, 2020
4e008e6
fix s3 linking
sshleifer Feb 7, 2020
60bd737
no cnn model
sshleifer Feb 7, 2020
a4edf2e
no cnn
sshleifer Feb 7, 2020
e1d106d
One kwarg for encoder_decoder_attention
sshleifer Feb 8, 2020
a9b979f
cleanup
sshleifer Feb 8, 2020
4b97345
BROKEN
sshleifer Feb 8, 2020
ed642cc
half fixed
sshleifer Feb 8, 2020
87ddeae
Merge remote-tracking branch 'upstream/master' into bart
sshleifer Feb 8, 2020
4628b7d
hoist split_kwargs
sshleifer Feb 9, 2020
a653c78
split out testing BartForSequenceClassification
sshleifer Feb 9, 2020
ab594b4
cleanup
sshleifer Feb 9, 2020
73f49a6
lmhead test passing
sshleifer Feb 9, 2020
f7d88db
calc loss in SeqClassification model
sshleifer Feb 9, 2020
8f04dd5
Fix newlines
sshleifer Feb 9, 2020
459aeaf
ci
sshleifer Feb 9, 2020
9ecee5b
comment public API
sshleifer Feb 10, 2020
aadf762
comments
sshleifer Feb 10, 2020
bac8348
reverted API changes
sshleifer Feb 10, 2020
66310db
style
sshleifer Feb 10, 2020
3f03344
isort
sshleifer Feb 10, 2020
808bbd5
Revert "isort"
sshleifer Feb 10, 2020
92b5f6e
some cleanup
sshleifer Feb 10, 2020
21ac214
Merge remote-tracking branch 'upstream/master' into bart
sshleifer Feb 10, 2020
2196cc2
Sty works here
sshleifer Feb 10, 2020
960af22
cleanup
sshleifer Feb 10, 2020
a812adc
fix slow tests
sshleifer Feb 10, 2020
a8a7839
long
sshleifer Feb 10, 2020
49f60d7
cleanup
sshleifer Feb 10, 2020
376a358
cleanup
sshleifer Feb 10, 2020
8ecdd0d
rename BartForMaskedLM
sshleifer Feb 10, 2020
537af62
use masked loss
sshleifer Feb 10, 2020
02b56df
Merge remote-tracking branch 'upstream/master' into bart
sshleifer Feb 10, 2020
765c98a
Merge remote-tracking branch 'upstream/master' into bart
sshleifer Feb 11, 2020
4e1a5e0
Factor in RobertaTokenizer changes
sshleifer Feb 12, 2020
4339102
delete reorder_ functions
sshleifer Feb 12, 2020
3ce6c1e
pop ignore keys
sshleifer Feb 12, 2020
fd3d991
Fix S3 URLs
sshleifer Feb 12, 2020
b22b368
Conform to t5 API
sshleifer Feb 12, 2020
e5c3485
no head passing
sshleifer Feb 12, 2020
e2827b1
mnli passing
sshleifer Feb 13, 2020
4d49735
Generate works, other stuff broken
sshleifer Feb 13, 2020
ac1657b
Only test inputs embeds fails
sshleifer Feb 13, 2020
2a1260a
caching might work
sshleifer Feb 13, 2020
afbfdeb
Merge remote-tracking branch 'upstream/master' into bart
sshleifer Feb 13, 2020
82877e7
Merge remote-tracking branch 'upstream/master' into bart
sshleifer Feb 13, 2020
8252075
Naming changes, tests pass besides embeds
sshleifer Feb 13, 2020
6bacd55
Dont support inputs embeds
sshleifer Feb 13, 2020
71c345f
New signatures, mnli passing
sshleifer Feb 13, 2020
67a4cee
MNLI PASSING, still two masks
sshleifer Feb 13, 2020
6fd50b3
Padding test passes
sshleifer Feb 13, 2020
db3bc84
One combined attn mask
sshleifer Feb 14, 2020
264f6d1
temp revert
sshleifer Feb 14, 2020
ba25b7a
Passing shape test
sshleifer Feb 14, 2020
8f1e8b4
Style
sshleifer Feb 14, 2020
6124967
passing
sshleifer Feb 14, 2020
c01e719
cleanup
sshleifer Feb 14, 2020
5dfc207
test_shift_tokens_right
sshleifer Feb 14, 2020
dafdac8
Move public API to bottom of file
sshleifer Feb 16, 2020
40f7f79
cleanup return types
sshleifer Feb 16, 2020
e7ea674
Share create_position_ids_from_input_ids with roberta
sshleifer Feb 16, 2020
36e1adc
Initialize SequenceClassification correctly
sshleifer Feb 16, 2020
de2ced0
working. About to hoist inputs
sshleifer Feb 16, 2020
8b5bb52
tests pass with new API
sshleifer Feb 16, 2020
c2973d4
py35 compat: type hint in comment
sshleifer Feb 17, 2020
dbe0f4e
more require_torch
sshleifer Feb 17, 2020
a42ac9c
Fix merge conflict
sshleifer Feb 17, 2020
5faa0dd
Redo cached_states rename
sshleifer Feb 18, 2020
6a08f84
Make masks if user doesnt supply. Passing.
sshleifer Feb 18, 2020
c439e19
style
sshleifer Feb 18, 2020
6205ba6
Delete epically slow test
sshleifer Feb 18, 2020
cda9ced
style
sshleifer Feb 18, 2020
f3b4f21
start docs
sshleifer Feb 18, 2020
85c3b77
More docs
sshleifer Feb 18, 2020
5292ab3
style
sshleifer Feb 18, 2020
e2353c3
style
sshleifer Feb 18, 2020
16d2e2e
more docs
sshleifer Feb 18, 2020
2ede7ab
sty
sshleifer Feb 18, 2020
cb425f3
passing
sshleifer Feb 18, 2020
360db12
passing
sshleifer Feb 18, 2020
3c6f62d
style
sshleifer Feb 18, 2020
2d69571
passing
sshleifer Feb 18, 2020
de98500
some attention cleanup
sshleifer Feb 18, 2020
35d421b
docstrings
sshleifer Feb 18, 2020
9e66bbc
More coverage
sshleifer Feb 18, 2020
d546db4
More test coverage (test_chg branch)
sshleifer Feb 18, 2020
3a37397
kill dead
sshleifer Feb 18, 2020
9b97322
Failing tokenizer test
sshleifer Feb 19, 2020
0f2819c
some docs
sshleifer Feb 19, 2020
12b83b9
Docs work, but are innacurate
sshleifer Feb 19, 2020
12becba
newlne
sshleifer Feb 20, 2020
77578ac
merge upstream
sshleifer Feb 20, 2020
5990cfe
Style
sshleifer Feb 20, 2020
6cff072
Fix decoder_attention_mask test
sshleifer Feb 20, 2020
e032d06
Adopt roberta behavior
sshleifer Feb 20, 2020
5592784
lower tolerance tests
sshleifer Feb 20, 2020
0e0b9b1
Tests passing
sshleifer Feb 20, 2020
4a4723e
Delete input_prep test, its trivial
sshleifer Feb 20, 2020
4a212a2
test passing in mask
sshleifer Feb 20, 2020
086b17a
more coverage
sshleifer Feb 20, 2020
feaf207
Merge remote-tracking branch 'upstream/master' into bart
sshleifer Feb 20, 2020
2c8225a
Docs accurate
sshleifer Feb 20, 2020
300df06
revert generation change
sshleifer Feb 20, 2020
6db143e
improved docs
sshleifer Feb 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
kill dead
  • Loading branch information
@sshleifer
sshleifer committed Feb 18, 2020
commit 3a373977de0862595b599773648222f1f54d8d67
1 change: 0 additions & 1 deletion tests/test_modeling_bart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,6 @@ def test_mnli_inference(self):
inputs_dict = prepare_bart_inputs_dict(model.config, input_ids=input_ids_no_pad)
with torch.no_grad():
logits2 = model.forward(**inputs_dict)[0]
# logits2 = model.forward(**inputs_dict)[0]
_assert_tensors_equal(batched_logits[1], logits2, atol=1e-3)
_assert_tensors_equal(expected_slice, logits_arr, atol=1e-3)

Expand Down