Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tokenizer export for LLamaTokenizerFast #27222

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

mayank31398
Copy link
Contributor

What does this PR do?

Currently, LLamaTokenizerFast is not exporting add_bos_token and add_eos_token. This will fix this issue.

Fixes # (issue)
#23833
#23855 (comment)

this is not saving add_eos_token and add_bos_token.
@sgugger @ArthurZucker Can you guys take a look at this?

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@amyeroberts
Copy link
Collaborator

@mayank31398 Could you add the same fix to code llama's fast tokenizer?

@mayank31398
Copy link
Contributor Author

done @amyeroberts

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@mayank31398
Copy link
Contributor Author

@amyeroberts can you merge this?
this is blocking us :)

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks 😉

@LysandreJik LysandreJik merged commit b026b5c into huggingface:main Nov 6, 2023
18 checks passed
@mayank31398 mayank31398 deleted the fix-llama-export branch November 6, 2023 11:45
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants