[MMS] Update docs with HF TTS implementation #25907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
ArthurZucker
approved these changes
Sep 1, 2023
| Audio(waveform, rate=model.config.sampling_rate) | ||
| ``` | ||
|
|
||
| For certain languages with non-Roman alphabets, such as Arabic, Mandarin or Hindi, the [`uroman`](https://github.com/isi-nlp/uroman) |
There was a problem hiding this comment.
Suggested change
| For certain languages with non-Roman alphabets, such as Arabic, Mandarin or Hindi, the [`uroman`](https://github.com/isi-nlp/uroman) | |
| - For certain languages with non-Roman alphabets, such as Arabic, Mandarin or Hindi, the [`uroman`](https://github.com/isi-nlp/uroman) |
There was a problem hiding this comment.
Why add a bullet point here?
Comment on lines
+231
to
+232
| If required, you should apply the uroman package to your text inputs **prior** to passing them to the `VitsTokenizer`, | ||
| since currently the tokenizer does not support performing the pre-processing itself. |
There was a problem hiding this comment.
Do you think we should add this? With a if self.is_uroman: requires_backend ? Makes sense no?
There was a problem hiding this comment.
Can you also add an example of how to do this pre-processing?
There was a problem hiding this comment.
It's a perl package, not a Python package, so we can't import it. The only way of running uroman is through the command line, see discussion here: #24085 (comment)
There was a problem hiding this comment.
Added an example for pre-processing: d264692
Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
* [MMS] Update docs with HF TTS implementation * Update docs/source/en/model_doc/mms.md Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com> * add uromanise to docs --------- Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Following #24085, Transformers now contains an implementation of MMS-TTS. This PR updates the MMS docs to include a code-snippet using this implementation.
cc @osanseviero since this was something you flagged before, and also @Vaibhavs10 for viz