Revert "change version (#25387)" #25573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3a05e01.
ArthurZucker
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Good for me. Thanks both. cc @younesbelkada to be sure, is there something to do for the original issue in the meantime ?
younesbelkada
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Thanks a lot @SunMarc for taking care of this!
@ArthurZucker I don't think we can do much for the original issue as it is related to bitsandbytes 8-bit optimizers
|
The documentation is not available anymore as the PR was closed or merged. |
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
This reverts commit 3a05e01.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR revert #25387. As @younesbelkada pointed out, the training still works as expected if we don't use 8-bit optimizers. I will propose a fix in a follow-up PR.