Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints to Blip2QFormer, BigBirdForQA and ConditionalDetr family models #25488

Conversation

nablabits
Copy link
Contributor

What does this PR do?

Addresses a few type hints in #16059

Who can review?

@Rocketknight1 please

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 14, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me - thanks for the clean PR!

@Rocketknight1 Rocketknight1 merged commit 87c9d8a into huggingface:main Aug 14, 2023
@nablabits nablabits deleted the feature/add-type-hints-for-models-batch-1 branch August 23, 2023 06:19
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
…ly models (huggingface#25488)

* Add missing type hints to `BigBirdForQuestionAnswering`

* Add type hints to `Blip2QFormerModel`

* Add type hints for `ConditionalDetr` family
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants