Skip to content

set correct model input names for gptsw3tokenizer #24788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

DarioSucic
Copy link
Contributor

What does this PR do?

Makes it so the tokenizer doesn't output token_type_ids, as these break generation.

Seems like a harmless change, but I'm not sure what these are used for so let me know if this is the wrong approach!

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ArthurZucker @amyeroberts @ekgren @Apsod

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 12, 2023

The documentation is not available anymore as the PR was closed or merged.

@Apsod
Copy link
Contributor

Apsod commented Jul 13, 2023

LGTM
We're not using token type ids during training, so there is no reason for the tokenizer to output them, and doing so just leads to unintended behaviour.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me too if this is a fix, otherwise might affect other users who might be using them. Not being used in training would tell me that it's a fix! Thanks both for opening the issue and reviewing

@ArthurZucker ArthurZucker requested a review from amyeroberts July 13, 2023 11:39
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@amyeroberts amyeroberts merged commit a865b62 into huggingface:main Jul 14, 2023
Apsod added a commit to Apsod/transformers that referenced this pull request Jan 3, 2024
ArthurZucker pushed a commit that referenced this pull request Jan 3, 2024
* remove token_type_ids from model_input_names (like #24788)

* removed test that assumed token_type_ids should be present and updated a model reference so that it points to an available model)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants