Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate doc files to Markdown. #24376

Merged
merged 7 commits into from
Jun 20, 2023
Merged

Migrate doc files to Markdown. #24376

merged 7 commits into from
Jun 20, 2023

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Jun 20, 2023

What does this PR do?

The new UI in GitHub makes MDX pretty hard to read for diffs, so this PR migrates the doc files from mdx to md. This shouldn't break anything in the doc-builder.

@sgugger sgugger requested a review from LysandreJik June 20, 2023 15:40
@LysandreJik
Copy link
Member

I'd add a ⚠️ emoji as a prefix for the disclaimer, but other than that it looks good to me!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 20, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I checked out the PR and checked that there weren't any instances of mdx left.

utils/tests_fetcher.py Outdated Show resolved Hide resolved
Co-authored-by: Lysandre Debut <lysandre.debut@reseau.eseo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants