[Not to merge before 2023/06/28] Time to say goodbye to py37 😭 #24075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Collaborator
Author
|
test failures will be addressed soon by related authors. Not related to this PR. |
sgugger
reviewed
Jun 7, 2023
Collaborator
sgugger
left a comment
sgugger
left a comment
There was a problem hiding this comment.
There is also importlib_metadata (liene 416 in the setup) as well as some logic in utils.version that can be cleaned up.
amyeroberts
approved these changes
Jun 7, 2023
Contributor
amyeroberts
left a comment
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks for updating!
This was referenced Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Byebye!
EOL of python 3.7 is
2023/06/27.https://endoflife.date/python