Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[from_pretrained] imporve the error message when _no_split_modules is not defined #23861

Merged
merged 4 commits into from
May 30, 2023
Merged

[from_pretrained] imporve the error message when _no_split_modules is not defined #23861

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dd0cbc1
Better warning
ArthurZucker May 30, 2023
7ed1d5b
Merge branch 'main' of https://github.com/huggingface/transformers in…
ArthurZucker May 30, 2023
85759b7
Update src/transformers/modeling_utils.py
ArthurZucker May 30, 2023
c3de005
format line
ArthurZucker May 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/transformers/modeling_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2734,7 +2734,9 @@ def from_pretrained(cls, pretrained_model_name_or_path: Optional[Union[str, os.P
target_dtype = torch.int8

if model._no_split_modules is None:
raise ValueError(f"{model.__class__.__name__} does not support `device_map='{device_map}'` yet.")
raise ValueError(
f"{model.__class__.__name__} does not have a `_no_split_modules` attribute, thus it does not support `device_map='{device_map}'` yet. If you are using a model on the hub, we recommend to open a pull request to make sure they implement the `_no_split_modules` attribute."
ArthurZucker marked this conversation as resolved.
Show resolved Hide resolved
)
no_split_modules = model._no_split_modules
if device_map not in ["auto", "balanced", "balanced_low_0", "sequential"]:
raise ValueError(
Expand Down