Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add type hint in pipeline model argument #23740

Merged
merged 3 commits into from
May 30, 2023
Merged

add type hint in pipeline model argument #23740

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
113706f
add type hint in pipeline model argument
y3sar May 24, 2023
354431a
add pretrainedmodel and tfpretainedmodel type hint
y3sar May 24, 2023
070a32c
make type hints string
y3sar May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/transformers/pipelines/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,7 @@ def clean_custom_task(task_info):

def pipeline(
task: str = None,
model: Optional = None,
model: Optional[Union[str, Path]] = None,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the instances are str, PreTrainedModel or TFPreTrainedModel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fast reply. So Path object shouldn't be there?

config: Optional[Union[str, PretrainedConfig]] = None,
tokenizer: Optional[Union[str, PreTrainedTokenizer, "PreTrainedTokenizerFast"]] = None,
feature_extractor: Optional[Union[str, PreTrainedFeatureExtractor]] = None,
Expand Down