Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export to ONNX doc refocused on using optimum, added tflite #23434

Merged
merged 7 commits into from
May 24, 2023
Merged

Export to ONNX doc refocused on using optimum, added tflite #23434

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
db4a349
doc refocused on using optimum, tflite
MKhalusova May 17, 2023
b16360c
minor updates to fix checks
MKhalusova May 17, 2023
ab5b8ca
Apply suggestions from code review
MKhalusova May 18, 2023
534f8b6
TFLite to separate page, added links
MKhalusova May 18, 2023
1280dfa
Removed the onnx list builder
MKhalusova May 18, 2023
35a9357
make style
MKhalusova May 18, 2023
f10a2a7
Update docs/source/en/serialization.mdx
MKhalusova May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/source/en/_toctree.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
- local: sagemaker
title: Run training on Amazon SageMaker
- local: serialization
title: Export to ONNX
title: Export to ONNX, TFLite
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have two different pages for ONNX and TFLite because one has to scroll down quite a lot to see the TFLite content. WDYT?
Also, there is a dedicated section for TorchScript just below, so I think we should do the same with TFLite.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, we can split this into two pages and add more content when there's more functionality

- local: torchscript
title: Export to TorchScript
- local: benchmarks
Expand Down
Loading