Removing one of the twice defined position_embeddings in LongFormer #23343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The self.position_embeddings in LongFormerEmbeddings is defined twice. Removing the first with padding_idx
GregorySenay
changed the title
GregorySenay
changed the title
|
The documentation is not available anymore as the PR was closed or merged. |
GregorySenay
changed the title
younesbelkada
approved these changes
May 15, 2023
5 tasks
sheonhan
pushed a commit
to sheonhan/transformers
that referenced
this pull request
Jun 1, 2023
…uggingface#23343) Removing twice defined position_embeddings The self.position_embeddings in LongFormerEmbeddings is defined twice. Removing the first with padding_idx
gojiteji
pushed a commit
to gojiteji/transformers
that referenced
this pull request
Jun 5, 2023
…uggingface#23343) Removing twice defined position_embeddings The self.position_embeddings in LongFormerEmbeddings is defined twice. Removing the first with padding_idx
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
…uggingface#23343) Removing twice defined position_embeddings The self.position_embeddings in LongFormerEmbeddings is defined twice. Removing the first with padding_idx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The self.position_embeddings in LongFormerEmbeddings is defined twice. Removing the first without padding_idx
l. 451/452
Who can review?