Skip to content

Conversation

@HanNayeoniee
Copy link
Contributor

@HanNayeoniee HanNayeoniee commented Apr 24, 2023

What does this PR do?

Fixes #22838

image

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Team PseudoLab, may you please review this PR?
@0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd

May you please review this PR?
@sgugger, @ArthurZucker, @eunseojo

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 24, 2023

The documentation is not available anymore as the PR was closed or merged.

@wonhyeongseo
Copy link
Contributor

wonhyeongseo commented Apr 24, 2023

LGTM. If you may, please:

  • amend your commit message to be more descriptive than just fixed.
    (e.g. fix: docs: missing newline before code block)
  • (Optional) provide relevant screenshots of your fixes

@HanNayeoniee
Copy link
Contributor Author

LGTM. If you may, please:

  • amend your commit message to be more descriptive than just fixed.
    (e.g. fix: docs: missing newline before code block)
  • (Optional) provide relevant screenshots of your fixes

Thanks for your review!
I amended the last commit message and added a screenshot in my first comment!

Copy link
Contributor

@wonhyeongseo wonhyeongseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot-on 🙌

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! 🤗

@ArthurZucker ArthurZucker merged commit f0f5e28 into huggingface:main Apr 25, 2023
@HanNayeoniee HanNayeoniee deleted the fix-ko-mlm branch April 25, 2023 14:18
gojiteji pushed a commit to gojiteji/transformers that referenced this pull request Jun 5, 2023
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants