Skip to content

🌐 [i18n-KO] Translated tutorial/proprecssing.mdx to Korean #22578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Apr 14, 2023
Merged

🌐 [i18n-KO] Translated tutorial/proprecssing.mdx to Korean #22578

merged 24 commits into from
Apr 14, 2023

Conversation

sim-so
Copy link
Contributor

@sim-so sim-so commented Apr 5, 2023 •
edited
Loading

What does this PR do?

Translated partially the documentation tutorial/proprecessing.mdx to Korean.

  • Proprecessing μ „μ²˜λ¦¬
    • Natural Language Processing μžμ—°μ–΄μ²˜λ¦¬
      • Pad νŒ¨λ”©
      • Trancation μƒλž΅
      • Build Tensor ν…μ„œ λ§Œλ“€κΈ°
    • Audio μ˜€λ””μ˜€
    • Computer Vision 컴퓨터 λΉ„μ „
      • Pad νŒ¨λ”©
    • Multimodal λ©€ν‹°λͺ¨λ‹¬

Thank you in advance for your review!

Part of #20179

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Team PsedoLab, could you review this PR?

@wonhyeongseo @0525hhgus @kihoon71 @gabrielwithappy, @HanNayeoniee, @jungnerd

@sim-so sim-so changed the title Ko preprocessing Ko [WIP]🌐 [i18n-KO] Translated tutorial/proprecssing.mdx to Korean Apr 5, 2023
@sim-so sim-so changed the title Ko [WIP]🌐 [i18n-KO] Translated tutorial/proprecssing.mdx to Korean [WIP]🌐 [i18n-KO] Translated tutorial/proprecssing.mdx to Korean Apr 5, 2023
@sim-so sim-so changed the title [WIP]🌐 [i18n-KO] Translated tutorial/proprecssing.mdx to Korean [WIP]🌐 [i18n-KO] Translated tutorial/proprecssing.mdx to Korean Apr 5, 2023
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 5, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@wonhyeongseo wonhyeongseo mentioned this pull request Apr 5, 2023
Open
84 tasks
@gabrielwithappy
Copy link
Contributor

@sim-so keep it up πŸ‘ :-)

gabrielwithappy
gabrielwithappy suggested changes Apr 8, 2023
View reviewed changes
Copy link
Contributor

@gabrielwithappy gabrielwithappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my review :-)

@sim-so sim-so force-pushed the ko-preprocessing branch from 6f34044 to ec7ed13 Compare April 8, 2023 03:33
@sim-so
Copy link
Contributor Author

sim-so commented Apr 8, 2023 •
edited
Loading

Some updates!

  • Newly translated two parts of this documentation: Build Tensors and Audio
  • Revised the sentence with the feedback as below:
    ν† ν¬λ‚˜μ΄μ €κ°€ 두 개의 νŠΉμˆ˜ν•œ 토큰(λΆ„λ₯˜ 토큰 CLS와 ꡬ뢄 토큰 SEP)을 λ¬Έμž₯에 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
  • Translated and revised all feature extractor to νŠΉμ§• μΆ”μΆœκΈ° based on TTA.

I am going to finish it by this Sunday. Thank you all in advance! πŸ˜„

0525hhgus
0525hhgus reviewed Apr 8, 2023
View reviewed changes
sim-so added 3 commits April 8, 2023 14:28
@sim-so
Update preprocessing.mdx
5686252 
Fixed the line 273 as below:
λ˜ν•œ, νŠΉμ§• μΆ”μΆœκΈ°μ— `sampling_rate` 인자λ₯Ό μΆ”κ°€ν•˜μ—¬ λ°œμƒν•  수 μžˆλŠ” μ‘°μš©ν•œ 였λ₯˜(silent errors)λ₯Ό 더 잘 λ””λ²„κΉ…ν•˜λŠ” 것을 ꢌμž₯ν•©λ‹ˆλ‹€.
@sim-so
translate Image part
06252e0
@sim-so
translated preprocess.mdx
b08d28a
@sim-so
Copy link
Contributor Author

sim-so commented Apr 9, 2023

I translated all of this document.
Thank you in advance for your review! πŸ˜‰

0525hhgus
0525hhgus reviewed Apr 9, 2023
View reviewed changes
Copy link
Contributor

@0525hhgus 0525hhgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the good translation πŸ‘
Please check the comments below πŸ˜ƒ

wonhyeongseo
wonhyeongseo suggested changes Apr 9, 2023
View reviewed changes
Copy link
Contributor

@wonhyeongseo wonhyeongseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I loved reading your translation. See you soon, @sim-so !

gabrielwithappy
gabrielwithappy approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@gabrielwithappy gabrielwithappy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me! :-) πŸ‘
I think you can ask review to πŸ€— members.

sim-so and others added 8 commits April 13, 2023 12:27
@sim-so @wonhyeongseo
Update docs/source/ko/preprocessing.mdx
e8cd336 
Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>
@sim-so @wonhyeongseo
Update docs/source/ko/preprocessing.mdx
2491e9f 
Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>
@sim-so @wonhyeongseo
Update docs/source/ko/preprocessing.mdx
40a2f17 
Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>
@sim-so @wonhyeongseo
Update docs/source/ko/preprocessing.mdx
a457d97 
Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>
@sim-so @wonhyeongseo
Update docs/source/ko/preprocessing.mdx
952dc9a 
Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>
@sim-so @wonhyeongseo
Update docs/source/ko/preprocessing.mdx
4d700cf 
Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>
@sim-so @wonhyeongseo
Update docs/source/ko/preprocessing.mdx
8f57019 
Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>
@sim-so @wonhyeongseo
Update docs/source/ko/preprocessing.mdx
f7ac068 
Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>
sim-so
sim-so commented Apr 13, 2023
View reviewed changes
Copy link
Contributor Author

@sim-so sim-so left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to your reviews, I fixed several lines. πŸ˜„

@sim-so
Copy link
Contributor Author

sim-so commented Apr 13, 2023

λ‹€λ₯Έ λ¬Έμ„œλ“€μ„ μ°Έκ³ ν•˜μ—¬ 일뢀 λ‹¨μ–΄μ˜ λ²ˆμ—­μ–΄λ₯Ό λͺ¨λ‘ λ³€κ²½ν–ˆμŠ΅λ‹ˆλ‹€.

  • argument -> 인수
  • feature extractor -> νŠΉμ„± μΆ”μΆœκΈ°
  • method -> λ©”μ†Œλ“œ
  • separator([SEP]) -> λΆ„ν•  토큰

@sim-so
Copy link
Contributor Author

sim-so commented Apr 14, 2023

Could you review this PR?
@sgugger, @ArthurZucker, @eunseojo

sgugger
sgugger approved these changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution!

@sgugger sgugger merged commit c8df390 into huggingface:main Apr 14, 2023
@sim-so sim-so changed the title [WIP]🌐 [i18n-KO] Translated tutorial/proprecssing.mdx to Korean 🌐 [i18n-KO] Translated tutorial/proprecssing.mdx to Korean Apr 15, 2023
@sim-so sim-so deleted the ko-preprocessing branch April 15, 2023 10:17
@sim-so sim-so mentioned this pull request Jun 10, 2023
Merged
10 tasks
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
@sim-so @wonhyeongseo @novice03
[WIP]🌐 [i18n-KO] Translated tutorial/proprecssing.mdx to Korean (hu…
932af2a 
…ggingface#22578)

* add ko preprocessing

* translate preprocessing.mdx to korean

* translate preprocessing.mdx

* Update preprocessing.mdx

Fixed the line 273 as below:
λ˜ν•œ, νŠΉμ§• μΆ”μΆœκΈ°μ— `sampling_rate` 인자λ₯Ό μΆ”κ°€ν•˜μ—¬ λ°œμƒν•  수 μžˆλŠ” μ‘°μš©ν•œ 였λ₯˜(silent errors)λ₯Ό 더 잘 λ””λ²„κΉ…ν•˜λŠ” 것을 ꢌμž₯ν•©λ‹ˆλ‹€.

* translate Image part

* translated preprocess.mdx

* Update docs/source/ko/preprocessing.mdx

Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>

* Update docs/source/ko/preprocessing.mdx

Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>

* Update docs/source/ko/preprocessing.mdx

Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>

* Update docs/source/ko/preprocessing.mdx

Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>

* Update docs/source/ko/preprocessing.mdx

Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>

* Update docs/source/ko/preprocessing.mdx

Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>

* Update docs/source/ko/preprocessing.mdx

Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>

* Update docs/source/ko/preprocessing.mdx

Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>

* Update docs/source/ko/preprocessing.mdx

* Update docs/source/ko/preprocessing.mdx

* Update docs/source/ko/preprocessing.mdx

* Update docs/source/ko/preprocessing.mdx

* Update docs/source/ko/preprocessing.mdx

* Update docs/source/ko/preprocessing.mdx

* fixed translation

---------

Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0525hhgus 0525hhgus 0525hhgus left review comments

@wonhyeongseo wonhyeongseo wonhyeongseo requested changes

@sgugger sgugger sgugger approved these changes

@gabrielwithappy gabrielwithappy gabrielwithappy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sim-so @HuggingFaceDocBuilderDev @gabrielwithappy @wonhyeongseo @sgugger @0525hhgus