Move torch.compile() wrapping after DDP/FSDP wrapping to ensure correct graph breaks during training #22279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct graph breaks during training
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Mar 20, 2023
|
I don't have permissions to merge the PR, so I don't know what the process looks like from here |
|
I was just waiting for the tests to complete ;-) |
raghavanone
pushed a commit
to raghavanone/transformers
that referenced
this pull request
Apr 5, 2023
…ct graph breaks during training (huggingface#22279)
4 tasks
4 tasks
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
…ct graph breaks during training (huggingface#22279)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a simple PR that moves the wrapper for torch.compile() after those for DDP and FSDP, given that the order is important for those two pieces to work together during training.
Fixes #22215
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@sgugger