Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup quality #21493

Merged
merged 4 commits into from
Feb 7, 2023
Merged

Cleanup quality #21493

merged 4 commits into from
Feb 7, 2023

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Feb 7, 2023

What does this PR do?

This PR cleans up a couple of things after the big #21480

  • adds the ruff cache to gitignore just in case (that folders comes with its own auto-generated gitignore so shouldn't be necessary but better be safe)
  • remove all mentions of flake8 and isort from the doc
  • use the per file rules to enable back quality checks on all inits.

@sgugger sgugger requested a review from LysandreJik February 7, 2023 16:23
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 7, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

LysandreJik
LysandreJik approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! Nice to not have this header anymore

@sgugger sgugger merged commit 67d0748 into main Feb 7, 2023
@sgugger sgugger deleted the cleanup_quality branch February 7, 2023 17:27
@regisss regisss mentioned this pull request Feb 8, 2023
Merged
3 tasks
@ArthurZucker ArthurZucker mentioned this pull request Feb 8, 2023
Merged
@echarlaix echarlaix mentioned this pull request Apr 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sgugger @HuggingFaceDocBuilderDev @LysandreJik