[Whisper] Move decoder id method to tokenizer #20589
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves the method
get_decoder_prompt_ids
from the processor to the tokenizer. The primary reason for this change is that the ASR pipeline class does not load the processor object, but rather the feature extractor and tokenizer separately (see docs). Therefore, as things currently stand, pipeline does not have access to the processor methodget_decoder_prompt_ids
. By moving it to the tokenizer, it will be able to call this method with pipeline.Note that this is not a breaking change: we retain a method
get_decoder_prompt_ids
in the processor. This method simply calls theget_decoder_prompt_ids
from the tokenizer:transformers/src/transformers/models/whisper/processing_whisper.py
Lines 44 to 45 in ca8b332
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.