Skip to content

python3 instead of python in Push CI setup job#19492

Merged
ydshieh merged 1 commit intomainfrom
fix_serious_push_ci_problem
Oct 11, 2022
Merged

python3 instead of python in Push CI setup job#19492
ydshieh merged 1 commit intomainfrom
fix_serious_push_ci_problem

Conversation

@ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Oct 11, 2022

What does this PR do?

The setup job in push CI uses image transformers-all-latest-gpu-push-ci, which should use python3 instead of python.
(I forgot this detail when working on #19054)

Currently, the setup job failed, and no test to run.

@ydshieh ydshieh requested a review from sgugger October 11, 2022 16:32
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 11, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there still a python2 in that env...

@ydshieh
Copy link
Collaborator Author

ydshieh commented Oct 11, 2022

Actually, python is not found. I think we need to tweak a bit if we want to use python as python3. Do you want me to work on the docker image for this purpose?

/__w/_temp/5f33851e-ac7e-4126-b3d7-88092ae0b56d.sh: 2: python: not found

@sgugger
Copy link
Collaborator

sgugger commented Oct 11, 2022

No, don't worry. I was just complaining about the action env, not your PR :-)

@ydshieh ydshieh merged commit 8d68878 into main Oct 11, 2022
@ydshieh ydshieh deleted the fix_serious_push_ci_problem branch October 11, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants