Added type hints to ResNetForImageClassification#19084
Merged
Rocketknight1 merged 2 commits intohuggingface:mainfrom Sep 19, 2022
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Running fix-copies changed the type hints for RegNetForImageClassification in modeling_regnet.py file
Contributor
Author
|
Thanks @Rocketknight1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on Issue #16059.
While looking into Issue #16059, I found that the
ResNetForImageClassificationmodel's type hints are inconsistent with the docs. Modified it to be consistent with the docs.@Rocketknight1 Could you kindly check if this is fine?
This is my First PR for the Transformers library. Thanks in advance.