Skip to content

model.tie_weights() should be applied after accelerator.prepare()#18676

Merged
muellerzr merged 3 commits intohuggingface:mainfrom
Gladiator07:patch-1
Aug 18, 2022
Merged

model.tie_weights() should be applied after accelerator.prepare()#18676
muellerzr merged 3 commits intohuggingface:mainfrom
Gladiator07:patch-1

Conversation

@Gladiator07
Copy link
Contributor

What does this PR do?

Weight tying should be done after the model has been moved to XLA device as mentioned on PyTorch/XLA Troubleshooting guide here. This PR fixes this in examples/pytorch/language-modeling/run_mlm_no_trainer.py example script.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review ?

@sgugger @muellerzr

Weight tying should be done after the model has been moved to XLA device as mentioned on PyTorch/XLA Troubleshooting guide [here](https://github.com/pytorch/xla/blob/master/TROUBLESHOOTING.md#xla-tensor-quirks)
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 18, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Indeed, this is the right way to go about this. In Accelerate it'd probably also be good to do this by default, similar to how Trainer does it

Could you run make style; make quality to pass the quality checks?

@muellerzr
Copy link
Contributor

Thanks @Gladiator07 great work!

@muellerzr muellerzr merged commit e54a1b4 into huggingface:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants