Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image build in parallel #17434

Merged
merged 4 commits into from
May 31, 2022
Merged

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented May 26, 2022

What does this PR do?

Remove needs in .github/workflows/build-docker-images.yml, as it can run in parallel now.

See this run page v.s. the previous run page, with 14 mins. v.s. 40 mins.

@ydshieh ydshieh requested a review from LysandreJik May 26, 2022 07:45
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 26, 2022

The documentation is not available anymore as the PR was closed or merged.

@ydshieh ydshieh force-pushed the test_docker_image_build_in_parallel branch from 95b77c1 to 97fa483 Compare May 26, 2022 14:06
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the images still manage to get pushed :)

@ydshieh
Copy link
Collaborator Author

ydshieh commented May 30, 2022

From the job run page, I saw

#18 exporting to image
#18 pushing layers 35.6s done
#18 pushing manifest for docker.io/huggingface/transformers-all-latest-gpu:latest@sha256:d8523684a112bff61a2899a69e06e05e26c507778df4754454b95c3dcf244012
#18 pushing manifest for docker.io/huggingface/transformers-all-latest-gpu:latest@sha256:d8523684a112bff61a2899a69e06e05e26c507778df4754454b95c3dcf244012 0.3s done
#18 DONE 289.9s
ImageID
  sha256:08ed1b5cc8db313f116b58d86292b2e109f0552737088fba4a5c672012bca3ae
Digest
  sha256:d8523684a112bff61a2899a69e06e05e26c507778df4754454b95c3dcf244012

so it looks fine to me. But I will run it again and verify the images on docker hub to make sure!

@ydshieh ydshieh merged commit 400b309 into main May 31, 2022
@ydshieh ydshieh deleted the test_docker_image_build_in_parallel branch May 31, 2022 13:39
Narsil pushed a commit to Narsil/transformers that referenced this pull request Jun 7, 2022
* docker image build in parallel

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
* docker image build in parallel

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Jun 16, 2022
* docker image build in parallel

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants