Skip to content

Fix missing "models" in pipeline test module #17090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2022

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented May 4, 2022

What does this PR do?

My PR #17034 forgot to update

package=f"tests.{model_slug}"

to

package=f"tests.models.{model_slug}"

which lead to a lot of pipeline tests being skipped.

Fixed it here.

@ydshieh ydshieh changed the title fix missing "models" in pipeline test module Fix missing "models" in pipeline test module May 4, 2022
@ydshieh ydshieh requested review from Narsil, sgugger and LysandreJik and removed request for Narsil May 4, 2022 19:30
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 4, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ydshieh ydshieh merged commit a59eb34 into huggingface:main May 5, 2022
@ydshieh ydshieh deleted the fix_pipeline_test branch May 5, 2022 14:12
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants