Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter --config_overrides for run_mlm_wwm.py #16961

Merged
merged 2 commits into from
Apr 28, 2022
Merged

Add parameter --config_overrides for run_mlm_wwm.py #16961

merged 2 commits into from
Apr 28, 2022

Conversation

conan1024hao
Copy link
Contributor

WHY

  • I noticed that the parameter --config_overrides is only available in run_clm.py, run_plm.py and run_mlm.py in examples/pytorch/language-modeling, but not available in run_mlm_wwm.py in examples/research_projects/mlm_wwm/run_mlm_wwm.py.
  • However, I want to train a wwm model from scratch too, so we need this parameter.

WHAT

  • Added the parameter --config_overrides in run_mlm_wwm.py.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 27, 2022

The documentation is not available anymore as the PR was closed or merged.

@conan1024hao
Copy link
Contributor Author

@sgugger @wlhgtc @LowinLi Please review this PR if you have time thank you.

@sgugger
Copy link
Collaborator

sgugger commented Apr 28, 2022

Thanks for your PR. Note that we don't maintain research projects, they are pinned to work with a specific version of Transformers. You will need approval from the original author of the script to have this merged :-)

@conan1024hao
Copy link
Contributor Author

@sgugger Thank you for reply. However I can not find the earliest history of run_mlm_wwm.py... Is @wlhgtc the original author?

@wlhgtc
Copy link
Contributor

wlhgtc commented Apr 28, 2022

@conan1024hao LGTM
And @sgugger can you help merge this PR ?

@sgugger sgugger merged commit 1be8d56 into huggingface:main Apr 28, 2022
@sgugger
Copy link
Collaborator

sgugger commented Apr 28, 2022

Sure thing!

elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
* dd parameter --config_overrides for run_mlm_wwm.py

* linter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants