[HF Argparser] Fix parsing of optional boolean arguments #16946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NielsRogge
commented
Apr 26, 2022
| @@ -103,7 +103,7 @@ def _parse_dataclass_field(parser: ArgumentParser, field: dataclasses.Field): | |||
| kwargs["default"] = field.default | |||
| else: | |||
| kwargs["required"] = True | |||
| elif field.type is bool or field.type is Optional[bool]: | |||
| elif field.type is bool or field.type == Optional[bool]: | |||
There was a problem hiding this comment.
I'm wondering whether we should use "==" everywhere for consistency, as we now have both "is" and "==".
There was a problem hiding this comment.
Fine by me. You should also fix the test on line 143 of this file :-)
|
The documentation is not available anymore as the PR was closed or merged. |
chamidullinr
pushed a commit
to chamidullinr/transformers
that referenced
this pull request
Apr 28, 2022
…#16946) * Add fix * Apply suggestion from code review Co-authored-by: Niels Rogge <nielsrogge@Nielss-MacBook-Pro.local>
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
…#16946) * Add fix * Apply suggestion from code review Co-authored-by: Niels Rogge <nielsrogge@Nielss-MacBook-Pro.local>
JunnYu
added a commit
to JunnYu/PaddleNLP
that referenced
this pull request
Aug 2, 2023
sijunhe
pushed a commit
to PaddlePaddle/PaddleNLP
that referenced
this pull request
Aug 2, 2023
triple-Mu
pushed a commit
to triple-Mu/PaddleNLP
that referenced
this pull request
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a weird bug that made optional boolean arguments not being recognized properly in my virtual environment.
Replacing "is" by "==" fixed the issue.