Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ACT2FN to fetch ReLU activation in the T5 model #16874

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Use ACT2FN to fetch ReLU activation in the T5 model #16874

merged 1 commit into from
Apr 21, 2022

Conversation

eldarkurtic
Copy link
Contributor

  • all activations should be fetched through ACT2FN
  • it returns ReLU as nn.Module, which allows attaching hooks on the activation function and prints it to stdout when print(model)

- all activations should be fetched through ACT2FN
- it returns ReLU as `nn.Module`, which allows attaching hooks on the activation function and prints it to stdout when `print(model)`
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 21, 2022

The documentation is not available anymore as the PR was closed or merged.

@LysandreJik LysandreJik merged commit bae9b64 into huggingface:main Apr 21, 2022
Narsil pushed a commit to Narsil/transformers that referenced this pull request Apr 21, 2022
- all activations should be fetched through ACT2FN
- it returns ReLU as `nn.Module`, which allows attaching hooks on the activation function and prints it to stdout when `print(model)`
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
- all activations should be fetched through ACT2FN
- it returns ReLU as `nn.Module`, which allows attaching hooks on the activation function and prints it to stdout when `print(model)`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants