Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not initialize torch.distributed process group if one is already initailized #16487

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

Yard1
Copy link
Contributor

@Yard1 Yard1 commented Mar 29, 2022

What does this PR do?

If a torch.distributed process group is already initialized, TrainingArguments will not initialize one by itself. This allows for the user to create their own custom process groups if needed.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Yard1
Copy link
Contributor Author

Yard1 commented Mar 29, 2022

cc @sgugger

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for tackling this! LGTM with a tiny nit on the warning message.

src/transformers/sagemaker/training_args_sm.py Outdated Show resolved Hide resolved
src/transformers/training_args.py Outdated Show resolved Hide resolved
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 29, 2022

The documentation is not available anymore as the PR was closed or merged.

@sgugger sgugger merged commit 277d49a into huggingface:main Mar 29, 2022
@Yard1 Yard1 deleted the do_not_initialize_process_group_twice branch March 29, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants