Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example test and test_fetcher for examples #16478

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Fix example test and test_fetcher for examples #16478

merged 1 commit into from
Mar 29, 2022

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Mar 29, 2022

What does this PR do?

#16475 introduced a failure in the example tests that went undetected because the test_fetcher had the wrong path for the example test. This PR fixes both.

@sgugger sgugger requested a review from LysandreJik March 29, 2022 16:12
@sgugger
Copy link
Collaborator Author

sgugger commented Mar 29, 2022

Confirmed this fixes the oversight in test_fetcher and fixes the actual example since the example tests actually ran (and passed) here. Since this is a failure on master merging without review but happy to address comments in a follow-up PR!

@sgugger sgugger merged commit b62ac4d into main Mar 29, 2022
@sgugger sgugger deleted the fix_example branch March 29, 2022 16:21
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 29, 2022

The documentation is not available anymore as the PR was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants