Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kwargs argument from IBERT MLM forward pass #16449

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Conversation

lewtun
Copy link
Member

@lewtun lewtun commented Mar 28, 2022

What does this PR do?

This PR fixes a small bug that was introduced in #16389 where a kwargs argument was added to the forward pass of the MLM IBERT class.

Once this is merged, the slow ONNX test for this model should also pass.

@lewtun lewtun requested review from Rocketknight1 and sgugger March 28, 2022 13:46
Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 28, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@lewtun lewtun merged commit c85547a into main Mar 28, 2022
@lewtun lewtun deleted the fix-ibert-mlm branch March 28, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants