Skip equivalence test for TransfoXL #16224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgugger
approved these changes
Mar 17, 2022
tests/test_modeling_tf_common.py
Outdated
| @@ -476,7 +476,7 @@ def check_pt_tf_models(tf_model, pt_model): | |||
| "TFFunnelForPreTraining", | |||
| "TFElectraForPreTraining", | |||
| "TFXLMWithLMHeadModel", | |||
| ]: | |||
| ] + ["TFTransfoXLLMHeadModel"]: | |||
There was a problem hiding this comment.
Doesn't it make more sense to add it in the list?
There was a problem hiding this comment.
Copied it from above, but you're right! Will fix both.
There was a problem hiding this comment.
I separate it to highlight the issue for TFTransfoXLLMHeadModel is somehow different than in other models. (losses). But I am OK for this change.
|
The documentation is not available anymore as the PR was closed or merged. |
FrancescoSaverioZuppichini
pushed a commit
that referenced
this pull request
Mar 21, 2022
* Skip test for TransfoXL * Single list
FrancescoSaverioZuppichini
pushed a commit
that referenced
this pull request
Mar 24, 2022
* Skip test for TransfoXL * Single list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skips the equivalence test for TransfoXL as it does not have the
lossorlossesreturned.