Add GLPN #16199
Merged
Add GLPN #16199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
FrancescoSaverioZuppichini
approved these changes
Mar 16, 2022
sgugger
approved these changes
Mar 16, 2022
Comment on lines
+412
to
+414
| return BaseModelOutput( | ||
| last_hidden_state=hidden_states, | ||
| hidden_states=all_hidden_states, | ||
| attentions=all_self_attentions, | ||
| ) |
There was a problem hiding this comment.
Suggested change
| return BaseModelOutput( | |
| last_hidden_state=hidden_states, | |
| hidden_states=all_hidden_states, | |
| attentions=all_self_attentions, | |
| ) | |
| return BaseModelOutput( | |
| last_hidden_state=hidden_states, hidden_states=all_hidden_states, attentions=all_self_attentions | |
| ) |
Comment on lines
+534
to
+536
| return BaseModelOutput( | ||
| last_hidden_state=sequence_output, | ||
| hidden_states=encoder_outputs.hidden_states, | ||
| attentions=encoder_outputs.attentions, | ||
| ) |
There was a problem hiding this comment.
Suggested change
| return BaseModelOutput( | |
| last_hidden_state=sequence_output, | |
| hidden_states=encoder_outputs.hidden_states, | |
| attentions=encoder_outputs.attentions, | |
| ) | |
| return BaseModelOutput( | |
| last_hidden_state=hidden_states, hidden_states=all_hidden_states, attentions=all_self_attentions | |
| ) |
|
Ok I've addressed all comments. Waiting for the author to respond such that I can transfer the weights to his name. |
FrancescoSaverioZuppichini
approved these changes
Mar 21, 2022
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
FrancescoSaverioZuppichini
pushed a commit
that referenced
this pull request
Mar 24, 2022
* First draft * Fix logits calculation * Improve tests * Add copied from statements * Fix base_model_prefix * Improve implementation, upload new models * Update design * Fix integration test * Add model to README and toctree * Add document image * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com> * Add decoder_hidden_size attribute * Update design of decoder * Add DepthEstimatorOutput class * Rename in_index to head_in_index and add feature extractor tests * Apply suggestions from code review * Apply suggestions from code review * Update pretrained model name and add to doc tests * Remove test.py script * Update copied from statements and clean up Co-authored-by: Niels Rogge <nielsrogge@Nielss-MacBook-Pro.local> Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR implements GLPN, Global Local Path Networks, for state-of-the-art depth estimation (number 2 on paperswithcode for KITTI and NYUv2 benchmarks).
To do:
in_indexto something betterDepthEstimatorOutput