Add missing type hints for all flavors of RoBERTa PyTorch models. #16086
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I added type hints for all
RoBERTa
PyTorch classes as described in #16059 .As I commented on the linked issue,
CamemBERT
inherits fromRoBERTa
, so it should be also good for PyTorch version ofCamemBERT
models.@Rocketknight1
I was not sure about
encoder_hidden_states
andencoder_attention_mask
which havetorch.FloatTensor
as type in the docstring, but I don't know if it needs to be specified ortorch.Tensor
is enough. Tell me if I need to change that.EDIT: Oh it seems that I have put some
torch.LongTensor
likeinputs_ids
astorch.Tensor
.