Fix processors #15280
Closed
Fix processors #15280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
NielsRogge
commented
Jan 21, 2022
Comment on lines
+30
to
+32
| if is_sentencepiece_available(): | ||
| from transformers.models.xlm_roberta.tokenization_xlm_roberta import XLMRobertaTokenizer | ||
| from transformers.models.xlm_roberta.tokenization_xlm_roberta_fast import XLMRobertaTokenizerFast |
There was a problem hiding this comment.
We need to fix the imports of XLMRobertaTokenizer(Fast) below, as this will return an error in case sentencepiece is not available.
|
A much better fix was provided in #15549. Therefore, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR aims to fix import checks for processors of multi-modal models, like those of LayoutLMv2, TrOCR and ViLT.
The bare minimum for a processor is PIL (assuming one creates a processor by combining a feature extractor and a slow tokenizer). If one combines a feature extractor and a fast tokenizer, both PIL and tokenizers should be available.
Questions:
To do:
AutoTokenizerAPI in thefrom_pretrainedmethod)