Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename compute_loss in TF models #15207

Merged
merged 6 commits into from
Jan 19, 2022
Merged

Rename compute_loss in TF models #15207

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9d16a0b
Rename compute_loss to hf_compute_loss to avoid conflicts with the ne…
Rocketknight1 Jan 18, 2022
fe5a962
make style
Rocketknight1 Jan 18, 2022
108de26
Adding deprecation warning to `compute_loss`
Rocketknight1 Jan 18, 2022
fedf731
Fix sneaky reference to compute_loss
Rocketknight1 Jan 18, 2022
00898ea
Replace logger.warning with warnings.warn
Rocketknight1 Jan 19, 2022
50946da
Clarifying warning and deprecation timeline
Rocketknight1 Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Clarifying warning and deprecation timeline
  • Loading branch information
@Rocketknight1
Rocketknight1 committed Jan 19, 2022
commit 50946daffc7a8dbb1b296eaf320adbc15260a46b
3 changes: 2 additions & 1 deletion src/transformers/modeling_tf_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -877,7 +877,8 @@ def compute_loss(self, *args, **kwargs):
warnings.warn(
"The old compute_loss method is deprecated as it conflicts with the Keras compute_loss "
"method added in TF 2.8. If you want the original HF compute_loss, please call "
"hf_compute_loss() instead.",
"hf_compute_loss() instead. From TF versions >= 2.8, or Transformers versions >= 5, "
"calling compute_loss() will get the Keras method instead.",
FutureWarning,
)
return self.hf_compute_loss(*args, **kwargs)
Expand Down