Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[urls to hub] Replace outdated model tags with their now-canonical pipeline types #14617

Merged
merged 2 commits into from
Dec 6, 2021

Conversation

julien-c
Copy link
Member

@julien-c julien-c commented Dec 3, 2021

Internal tracker 🌔

Context:

On the hub side, we are using the metadata generated by transformers (hat/tip @sgugger) to replace the pattern matching, BUT I'm also proposing to take this opportunity to remove the lm-head, seq2seq, causal-lm, masked-lm auto-generated tags (it's still possible to add them manually to a model card, of course)

(they are superseded by the pipeline tag aka. what we call the Task on hf.co/models)

This might break some stuff though, which is why your feedback will be important.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no problem with this, thank you for taking care of it

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this!

Copy link
Contributor

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julien-c
Copy link
Member Author

julien-c commented Dec 6, 2021

also cc'ing @osanseviero for info before merging!

@julien-c julien-c closed this Dec 6, 2021
@julien-c julien-c reopened this Dec 6, 2021
@julien-c julien-c merged commit 6cdc3a7 into master Dec 6, 2021
@julien-c julien-c deleted the deprecated-model-tags branch December 6, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants