Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TF CTRL compliant with XLA and AMP #10209

Merged
merged 3 commits into from
Feb 17, 2021
Merged

Conversation

jplu
Copy link
Contributor

@jplu jplu commented Feb 16, 2021

What does this PR do?

This PR makes the TF CTRL model compliant with XLA and AMP. All the slow tests are passing as well.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM!

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing those!

@jplu jplu merged commit 7246785 into huggingface:master Feb 17, 2021
@jplu jplu deleted the tf-ctrl-amp-xla branch February 17, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants