-
Notifications
You must be signed in to change notification settings - Fork 31.2k
Closed
Labels
Should FixThis has been identified as a bug and should be fixed.This has been identified as a bug and should be fixed.VisionWIPLabel your PR/Issue with WIP for some long outstanding Issues/PRs that are work in progressLabel your PR/Issue with WIP for some long outstanding Issues/PRs that are work in progress
Description
System Info
In current implementation of VLMs, the "_supports_sdpa" attribute checks and activates SDPA attention only for the language model. For example in Llava
It should also check and if available use SDPA attention for vision tower.
- CLIP SDPA has an open PR: [CLIP] add: sdpa support to clip. #30390
- SigLip SDPA is merged: Add FA2 and
sdpasupport for SigLIP #31499
We can raise a warning for composite models if only one part support sdpa, but other does not, and activate SDPA for the supported part. That waythe user knows what is happening in the background.
Verified models
- BLIP-2
- InstructBLIP
- InstructBLIPVideo
- KOSMOS-2
- LLaVa
- LLaVa-NeXT
- LLaVa-NeXT-Video
- VipLLaVa
- Video-LLaVa
- Idefics
- Idefics2
- PaliGemma
Metadata
Metadata
Assignees
Labels
Should FixThis has been identified as a bug and should be fixed.This has been identified as a bug and should be fixed.VisionWIPLabel your PR/Issue with WIP for some long outstanding Issues/PRs that are work in progressLabel your PR/Issue with WIP for some long outstanding Issues/PRs that are work in progress