fix: bump @huggingface/jinja to ^0.5.9 for {%- generation -%} support#1725
Open
wwhsaber wants to merge 1 commit into
Open
fix: bump @huggingface/jinja to ^0.5.9 for {%- generation -%} support#1725wwhsaber wants to merge 1 commit into
wwhsaber wants to merge 1 commit into
Conversation
Chat templates that use `{%- generation -%}` (e.g. LiquidAI LFM models)
throw `Unknown statement type: generation` with jinja 0.5.6 because that
release only stripped plain `{% generation %}` tags.
@huggingface/jinja 0.5.8+ honors whitespace-control generation tags
(huggingface/huggingface.js#2124). Bump the dependency and lockfile so
installs resolve a fixed version.
Closes huggingface#1724
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@huggingface/jinjafrom^0.5.6→^0.5.9and updatespnpm-lock.yamlaccordingly.{%- generation -%}/{%- endgeneration -%}), as used by LiquidAI LFM models.Why
@huggingface/jinja@0.5.6only strips plain{% generation %}tags. Templates with{%- generation -%}leave agenerationstatement for the parser and throw:Support for whitespace-control generation tags was added in
@huggingface/jinja@0.5.8(huggingface/huggingface.js#2124). Latest published is0.5.9.Verification
Rendered a minimal template with
{%- generation -%}against both versions:Unknown statement type: generationPlain
{% generation %}continues to work on both.Test plan
{%- generation -%}@huggingface/transformersafter mergeCloses #1724