Conversation
nico-martin
reviewed
Jan 21, 2026
Collaborator
There was a problem hiding this comment.
tsc --build has 5 errors:
> tsc --build
src/models/vits/tokenization_vits.js:1:10 - error TS2305: Module '"@huggingface/tokenizers"' has no exported member 'Decoder'.
1 import { Decoder } from '@huggingface/tokenizers';
~~~~~~~
src/models/vits/tokenization_vits.js:6:16 - error TS8030: The type of a function declaration must match the function's signature.
6 /** @type {Decoder['decode_chain']} */
~~~~~~~~~~~~~~~~~~~~~~~
src/models/vits/tokenization_vits.js:20:51 - error TS2554: Expected 0 arguments, but got 1.
20 this._tokenizer.decoder = new VitsDecoder({});
~~
src/pipelines/fill-mask.js:104:21 - error TS2578: Unused '@ts-expect-error' directive.
104 // @ts-expect-error TS2367
~~~~~~~~~~~~~~~~~~~~~~~~~~
src/pipelines/text-generation.js:8:21 - error TS2307: Cannot find module '../tokenizers.js' or its corresponding type declarations.
8 * @typedef {import('../tokenizers.js').Message[]} Chat
~~~~~~~~~~~~~~~~~~
But other than that I have nothing to add. Great work!
Collaborator
Author
|
Thanks! Fixed those issues. The one tokenizers-related one should be fixable on your side by upgrading to v0.1 (maybe a clean install is needed, especially if you were building via local dev). Either way. Good to go for now, then will open up another PR for some pipeline types improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on huggingface/tokenizers.js#18, we now move all tokenizers logic to the dedicated
@huggingface/tokenizerslibrary.