Skip to content

V4 cache wasm file blob fix#1489

Merged
xenova merged 5 commits intov4from
v4-cache-wasm-file-blob-fix
Dec 21, 2025
Merged

V4 cache wasm file blob fix#1489
xenova merged 5 commits intov4from
v4-cache-wasm-file-blob-fix

Conversation

@nico-martin
Copy link
Collaborator

fixes an issue described in the conversation here:
#1471

Copy link
Collaborator

@xenova xenova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could we use isValidUrl?

function isValidUrl(string, protocols = null, validHosts = null) {
for this?

Example usage:

if (env.useFS && !isValidUrl(urlOrPath, ["http:", "https:", "blob:"])) {

@nico-martin
Copy link
Collaborator Author

Yes, you're right. I changed it!

Copy link
Collaborator

@xenova xenova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xenova xenova merged commit b4a44aa into v4 Dec 21, 2025
1 check failed
@xenova xenova deleted the v4-cache-wasm-file-blob-fix branch December 21, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants