Added target to playground link #1189
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set a more light color to the "locally" link - set a darker font color for token IDs to make them readable
Author
|
I added a new commit to this PR that fixes the colors in the playground. Some things are very difficult to read like the link "locally" to the repo and the token ids in the output text area when that option is selected |
Collaborator
|
Hi there 👋 Thanks for the PR! We have moved the examples source code to https://github.com/huggingface/transformers.js-examples; could you re-open this there? |
Author
|
Hello @xenova, I recreated the PR on the other repo. I will close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if I click the
locallylink in the course page, it breaks the iframe:This PR adds
target="_blank"to that link and fixes this issue.