Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sagemaker): add trust remote code to entrypoint #394

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

OlivierDehaene
Copy link
Member

@philschmid what do you think?
Fix #390

Copy link
Member

@philschmid philschmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would that mean we need to add another env when using it? Is that what you do for the inference API as well? Or do you fix the transformers fork?

@OlivierDehaene
Copy link
Member Author

OlivierDehaene commented Jun 1, 2023

Would that mean we need to add another env when using it? Is that what you do for the inference API as well?

Yes and yes

For falcon models I already merged #396 to allow them. This is only for future models.

@monuminu
Copy link

monuminu commented Jun 1, 2023

Hi @OlivierDehaene , I am stil getting error for Falcon model using sagemaker. Do you know how can fix this .

from sagemaker.huggingface import get_huggingface_llm_image_uri

# retrieve the llm image uri
llm_image = get_huggingface_llm_image_uri(
  "huggingface",
  version="0.7.0"
)

# print ecr image uri
print(f"llm image uri: {llm_image}")

@philschmid
Copy link
Member

Hi @OlivierDehaene , I am stil getting error for Falcon model using sagemaker. Do you know how can fix this .

from sagemaker.huggingface import get_huggingface_llm_image_uri

# retrieve the llm image uri
llm_image = get_huggingface_llm_image_uri(
  "huggingface",
  version="0.7.0"
)

# print ecr image uri
print(f"llm image uri: {llm_image}")

@monuminu for SageMaker we currenlty only have the 0.6.0 image available you can find the available versions here: https://github.com/aws/deep-learning-containers/blob/master/available_images.md#huggingface-text-generation-inference-containers

I hope we can soon add the new versions

Copy link
Member

@philschmid philschmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! what happens if the variable is not set? Is it the default None?

@OlivierDehaene
Copy link
Member Author

what happens if the variable is not set? Is it the default None?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trust_remote_code is not available in SageMaker Endpoint
3 participants