Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set MODEL_ID in sagemaker-entrypoint script #343

Merged
merged 1 commit into from
May 22, 2023

Conversation

xyang16
Copy link
Contributor

@xyang16 xyang16 commented May 19, 2023

What does this PR do?

Currently setting HF_MODEL_ID environment variable does not take effect. It will always use the default bloom model.

So I raise this PR to set MODEL_ID with HF_MODEL_ID in sagemaker-entrypoint script. I have tested it in SageMaker.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@OlivierDehaene OR @Narsil

@xyang16 xyang16 changed the title Set MODEL_ID in sagemaker-entrypoint script fix: set MODEL_ID in sagemaker-entrypoint script May 19, 2023
Copy link
Member

@OlivierDehaene OlivierDehaene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@OlivierDehaene OlivierDehaene merged commit 1ba7820 into huggingface:main May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants