Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incomplete generations w/ single tokens generations and models that did not support chunking #2770

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

OlivierDehaene
Copy link
Member

Related to #2754

sywangyi and others added 2 commits November 21, 2024 14:06
entries.len() could > batch.size in prefill, so need to filter as well.

Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
@OlivierDehaene OlivierDehaene changed the title fix: incomplete generations when generating single tokens with model that did not support chunking fix: incomplete generations w/ single tokens generations and models that did not support chunking Nov 21, 2024
Copy link
Member

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very familiar with this, but looks good.

@OlivierDehaene OlivierDehaene merged commit 8e0c161 into main Nov 21, 2024
8 of 10 checks passed
@OlivierDehaene OlivierDehaene deleted the fix/incomplete_generations branch November 21, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants