chore(github): add templates #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied almost verbatim from `transformers`, just modified the text and remove the extraneous options. - Need to create the CLI afterwards to enable outputting the env. (Probably 1 for docker, 1 for binary) - I left model addition on purpose. We might want to update the text just to clarify that it's different than adding it in transformers
launcher/build.rs
Outdated
| @@ -0,0 +1,24 @@ | |||
| use std::fs::File; | |||
There was a problem hiding this comment.
Can you use vergen like in the router?
https://github.com/huggingface/text-generation-inference/blob/main/router/build.rs
and then
https://github.com/huggingface/text-generation-inference/blob/main/router/src/server.rs#L636
It is also possible to ask the user to add values returned by GET /info.
There was a problem hiding this comment.
haha I still prefer no dependencies for that kind of things, but since you're already using it.
OlivierDehaene
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Copied almost verbatim from
transformers, just modified the text andremove the extraneous options.
(Probably 1 for docker, 1 for binary)
just to clarify that it's different than adding it in transformers
Added the CLI here, it's more convenient (it just runs the command listed in
bug-report.Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.