Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cpu perf #2596

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Cpu perf #2596

merged 2 commits into from
Oct 14, 2024

Conversation

Narsil
Copy link
Collaborator

@Narsil Narsil commented Oct 1, 2024

What does this PR do?

Superseeds #2582

Instead of dropping stdin all the time (which break debugger interatictivity which is the reason for the introduction of this stdin reading code, we instead protect the stdin reading with debug level logger, where which the performance drop shouldn't be too surprising (jsut the sheer amount of logging slows everything down)

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

sywangyi and others added 2 commits September 27, 2024 19:39
Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
is where dropping to a debugger is important).
@Narsil Narsil mentioned this pull request Oct 1, 2024
5 tasks
@Narsil Narsil merged commit 3ea82d0 into main Oct 14, 2024
11 of 12 checks passed
@Narsil Narsil deleted the cpu_perf branch October 14, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants