Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max token capacity metric #2595

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Max token capacity metric #2595

merged 4 commits into from
Oct 2, 2024

Conversation

Narsil
Copy link
Collaborator

@Narsil Narsil commented Oct 1, 2024 •
edited
Loading

What does this PR do?

Superseeds : #2279

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Narsil Narsil mentioned this pull request Oct 1, 2024
Closed
5 tasks
drbh
drbh approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@drbh drbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Narsil Narsil merged commit 0204946 into main Oct 2, 2024
11 of 12 checks passed
@Narsil Narsil deleted the max_token_capacity_metric branch October 2, 2024 14:32
@achandrasekar
Copy link

Thank you for adding this! This is super useful.

achandrasekar
achandrasekar reviewed Oct 4, 2024
View reviewed changes
Copy link

@achandrasekar achandrasekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metric is called tgi_batch_total_tokens in the describe_gauge function whereas it is called tgi_batch_max_total_tokens above where we are setting it. Shouldn't they be the same name?

yuanwu2017 pushed a commit to yuanwu2017/tgi-gaudi that referenced this pull request Oct 27, 2024
@Narsil @Edwinhr716 @yuanwu2017
Max token capacity metric (huggingface#2595)
967e671 
* adding max_token_capacity_metric

* added tgi to name of metric

* Adding max capacity metric.

* Add description for the metrics

---------

Co-authored-by: Edwinhr716 <Edandres249@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achandrasekar achandrasekar achandrasekar left review comments

@drbh drbh drbh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Narsil @achandrasekar @drbh @Edwinhr716